fix(sqlite): respect autoincrement: false in schema diffing

Closes #2800

packages/better-sqlite/src/BetterSqliteSchemaHelper.ts

@@ -23,7 +23,11 @@ export class BetterSqliteSchemaHelper extends SchemaHelper {
 
   async getColumns(connection: AbstractSqlConnection, tableName: string, schemaName?: string): Promise<any[]> {
     const columns = await connection.execute<any[]>(`pragma table_info('${tableName}')`);
+    const sql = `select sql from sqlite_master where type = ? and name = ?`;
+    const tableDefinition = await connection.execute<{ sql: string }>(sql, ['table', tableName], 'get');
     const composite = columns.reduce((count, col) => count + (col.pk ? 1 : 0), 0) > 1;
+    // there can be only one, so naive check like this should be enough
+    const hasAutoincrement = tableDefinition.sql.toLowerCase().includes('autoincrement');
 
     return columns.map(col => {
       const mappedType = connection.getPlatform().getMappedType(col.type);
@@ -35,7 +39,7 @@ export class BetterSqliteSchemaHelper extends SchemaHelper {
         primary: !!col.pk,
         mappedType,
         unsigned: false,
-        autoincrement: !composite && col.pk && this.platform.isNumericColumn(mappedType),
+        autoincrement: !composite && col.pk && this.platform.isNumericColumn(mappedType) && hasAutoincrement,
       };
     });
   }

packages/sqlite/src/SqliteSchemaHelper.ts

@@ -23,7 +23,11 @@ export class SqliteSchemaHelper extends SchemaHelper {
 
   async getColumns(connection: AbstractSqlConnection, tableName: string, schemaName?: string): Promise<any[]> {
     const columns = await connection.execute<any[]>(`pragma table_info('${tableName}')`);
+    const sql = `select sql from sqlite_master where type = ? and name = ?`;
+    const tableDefinition = await connection.execute<{ sql: string }>(sql, ['table', tableName], 'get');
     const composite = columns.reduce((count, col) => count + (col.pk ? 1 : 0), 0) > 1;
+    // there can be only one, so naive check like this should be enough
+    const hasAutoincrement = tableDefinition.sql.toLowerCase().includes('autoincrement');
 
     return columns.map(col => {
       const mappedType = connection.getPlatform().getMappedType(col.type);
@@ -35,7 +39,7 @@ export class SqliteSchemaHelper extends SchemaHelper {
         primary: !!col.pk,
         mappedType,
         unsigned: false,
-        autoincrement: !composite && col.pk && this.platform.isNumericColumn(mappedType),
+        autoincrement: !composite && col.pk && this.platform.isNumericColumn(mappedType) && hasAutoincrement,
       };
     });
   }

tests/features/schema-generator/__snapshots__/fk-diffing.sqlite.test.ts.snap

@@ -0,0 +1,7 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`dropping tables with FKs in postgres schema generator removes stale FKs on target table dropping 1 1`] = `
+"alter table \`sequence\` add column \`another_property\` text null;
+
+"
+`;

tests/features/schema-generator/fk-diffing.sqlite.test.ts

@@ -0,0 +1,101 @@
+import { Entity, ManyToOne, MikroORM, PrimaryKey, Property } from '@mikro-orm/core';
+
+@Entity()
+export class Door {
+
+  @PrimaryKey({ autoincrement: false })
+  id!: number;
+
+  @Property()
+  label!: string;
+
+  @Property({ default: true })
+  isEnabled!: boolean;
+
+  @Property()
+  state!: 'open' | 'closed';
+
+}
+
+@Entity({ tableName: 'sequence' })
+export class Sequence0 {
+
+  @PrimaryKey()
+  id!: number;
+
+  @Property()
+  index!: number;
+
+  @Property()
+  action!: 'on' | 'off' | 'low' | 'high';
+
+  @Property()
+  target!:
+    | 'relay1'
+    | 'relay2'
+    | 'relay3'
+    | 'digitalOutput1'
+    | 'digitalOutput2'
+    | 'digitalOutput3';
+
+  @Property()
+  duration!: number;
+
+  @ManyToOne(() => Door)
+  door!: Door;
+
+}
+
+@Entity({ tableName: 'sequence' })
+export class Sequence1 {
+
+  @PrimaryKey()
+  id!: number;
+
+  @Property()
+  index!: number;
+
+  @Property()
+  action!: 'on' | 'off' | 'low' | 'high';
+
+  @Property({ nullable: true })
+  anotherProperty?: string;
+
+  @Property()
+  target!:
+    | 'relay1'
+    | 'relay2'
+    | 'relay3'
+    | 'digitalOutput1'
+    | 'digitalOutput2'
+    | 'digitalOutput3';
+
+  @Property()
+  duration!: number;
+
+  @ManyToOne(() => Door)
+  door!: Door;
+
+}
+
+describe('dropping tables with FKs in postgres', () => {
+
+  test('schema generator removes stale FKs on target table dropping 1', async () => {
+    const orm = await MikroORM.init({
+      entities: [Sequence0, Door],
+      dbName: `:memory:`,
+      type: 'better-sqlite',
+      cache: { enabled: false },
+    });
+    await orm.getSchemaGenerator().refreshDatabase();
+
+    orm.getMetadata().reset('Sequence0');
+    await orm.discoverEntity([Sequence1]);
+    const diff1 = await orm.getSchemaGenerator().getUpdateSchemaSQL({ wrap: false });
+    expect(diff1).toMatchSnapshot();
+    await orm.getSchemaGenerator().execute(diff1);
+
+    await orm.close(true);
+  });
+
+});