fix(core): do not override child class properties (#1000)

mikro-orm · Oct 27, 2020 · 6d91f1f · 6d91f1f
1 parent 3371415
commit 6d91f1f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/core/src/metadata/MetadataDiscovery.ts b/packages/core/src/metadata/MetadataDiscovery.ts
@@ -511,11 +511,11 @@ export class MetadataDiscovery {
     }
 
     let order = this.defineBaseEntityProperties(base);
-    const old = Object.values(meta.properties);
+    const old = Object.values(meta.properties).map(x => x.name);
     meta.properties = { ...base.properties, ...meta.properties };
 
     if (!meta.discriminatorValue) {
-      Object.values(base.properties).filter(prop => !old.includes(prop)).forEach(prop => {
+      Object.values(base.properties).filter(prop => !old.includes(prop.name)).forEach(prop => {
         meta.properties[prop.name] = { ...prop };
         meta.propertyOrder.set(prop.name, (order += 0.01));
       });