fix(knex): respect explicit transaction in em.count() (#2818)

Co-authored-by: Asi Farran <[email protected]>
mikro-orm · Feb 24, 2022 · 2d26a63 · 2d26a63
1 parent 725ff91
commit 2d26a63
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/knex/src/AbstractSqlDriver.ts b/packages/knex/src/AbstractSqlDriver.ts
@@ -182,10 +182,10 @@ export abstract class AbstractSqlDriver<C extends AbstractSqlConnection = Abstra
     }
   }
 
-  async count<T extends AnyEntity<T>>(entityName: string, where: any, options: CountOptions<T> = {}, ctx?: Transaction<Knex.Transaction>): Promise<number> {
+  async count<T extends AnyEntity<T>>(entityName: string, where: any, options: CountOptions<T> = {}): Promise<number> {
     const meta = this.metadata.find(entityName)!;
     const pks = meta.primaryKeys;
-    const qb = this.createQueryBuilder(entityName, ctx, !!ctx, false)
+    const qb = this.createQueryBuilder(entityName, options.ctx, !!options.ctx, false)
       .groupBy(options.groupBy!)
       .having(options.having!)
       .populate(options.populate as unknown as PopulateOptions<T>[] ?? [])