Successfully build wheels #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the install scripts directory is not created during the install process (due to the package not containing any install scripts), but it does rely on the install_directories to manually install binaries. Fix the manual binary copying logic to check for the existence of the install_scripts directory and create it if necessary python setup.py bdist_wheel should work after this. Additionally, pip installing the package (even if no wheel exists) will succeed at generating the wheel dynamically.
|
Thanks, merged! Sorry for the late response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #190
This fixes an issue where the install_scripts directory is not created
during the install process (due to the package not containing any
install scripts), but it does rely on the install_directories to
manually install binaries. Fix the manual binary copying logic to check
for the existence of the install_scripts directory and create it if
necessary
python setup.py bdist_wheelshould work after this. Additionally, pipinstalling the package (even if no wheel exists) will succeed at
generating the wheel dynamically.