Quote arguments in shell scripts #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great suggestion, much better than my original "disallow spaces in file names" :) Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Same as #348 which accidentally got polluted)
When passing paths with certain characters, e.g. spaces, quotes, braces or similar to flye, its calls to samtools and minimap2 fail.
That is because these calls go via a shell that interprets some characters in its own way. By adding single quotes around all paths when forwarding to the shell, the shell does not alter the paths but passes them correctly to the underlying program.
This pull request does exactly that.
It might be useful to squash the commits of this pull request when merging, as there are quite many with very small semantic contributions.