path.py - fix system cannot move file to different drive

[AyluinReymaer]

When the gallery-dl config file is set to download the temporary files into one disk drive and then the base-directory set in extractor is set to another drive, the way path.py copies the file to the target destination like this on line 340, it fails with the below error:

OSError(18, 'The system cannot move the file to a different disk drive')

Since this is an OSError, it will retry on line 347.

This will cause yet another error:

Unable to download data: FileNotFoundError: [Errno 2] No such file or directory

To resolve this, we attempt to create the folder first before doing any move operations with the exists_ok=True flag so that in case the folder already exists it doesn't throw an exception.

sample config:

{
    "downloader": {
        "rate": "5M",
        "retries": 3,
        "timeout": 10.0,
        "part-directory": "./data/.tmp_download/",
        "mtime": false,
        "http": {
            "adjust-extensions": true
        }
    },
    "extractor": {
        "base-directory": "W:/gallery-dl/files",
        "archive": "./data/archives/{category}.sqlite3",
        "archive-prefix": "",
        "sleep": 1,
        "skip": "abort:20",
        "deviantart": {
            "client-id": null,
            "client-secret": null,
            "auto-watch": false,
            "auto-unwatch": false,
            "comments": false,
            "extra": false,
            "flat": true,
            "folders": false,
            "group": true,
            "include": "gallery",
            "journals": "html",
            "mature": true,
            "metadata": false,
            "original": true,
            "wait-min": 0
        }
    }
]

[mikf]

On non-Windows systems, exception order is reversed (first FileNotFoundError -> create directory, then OSError: [Errno 18] Invalid cross-device link -> shutil.copyfile) and everything works as it should.

[mikf]

diff --git a/gallery_dl/path.py b/gallery_dl/path.py
index 1616bbda..4b4d405b 100644
--- a/gallery_dl/path.py
+++ b/gallery_dl/path.py
@@ -344,7 +344,11 @@ class PathFormat():
                     continue
                 except OSError:
                     # move across different filesystems
-                    shutil.copyfile(self.temppath, self.realpath)
+                    try:
+                        shutil.copyfile(self.temppath, self.realpath)
+                    except FileNotFoundError:
+                        os.makedirs(self.realdirectory)
+                        shutil.copyfile(self.temppath, self.realpath)
                     os.unlink(self.temppath)
                 break
 

This calls os.makedirs only when necessary.

[AyluinReymaer]

That also works, also tested on my side.

I've committed the new changes like you've advised, hopefully this should also work on non-windows hosts, though I don't have a way to test it unfortunately