Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings flag #5474

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Add warnings flag #5474

merged 2 commits into from
Apr 16, 2024

Conversation

aidanharris
Copy link
Contributor

This commit adds a warnings flag

It can be combined with -q / --quiet to display warnings. The intent is to provide a silent option that still surfaces warning and error messages so that they are visible in logs.

I'm not entirely sure if this is the best approach or if there's already an existing way to accomplish this but with this I can run gallery-dl -q -w and I get silent output but still see warnings. Essentially, I want an option that's in-between -q and -v, -v is too noisy. I only want to see warning messages and error messages.

This commit adds a warnings flag

It can be combined with -q / --quiet to display warnings.
The intent is to provide a silent option that still surfaces
warning and error messages so that they are visible in logs.
@mikf
Copy link
Owner

mikf commented Apr 14, 2024

This is fine I think, but the help text should be a bit more specific - maybe "Print only warnings and errors" - and the option should be moved in-between -q and -v since it is, as you say, an option that's in-between -q and -v,

if there's already an existing way to accomplish this

There is, but having a shortcut cmdline option, especially if it's this simple, would be nice.

@mikf mikf merged commit 4cf24f1 into mikf:master Apr 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants