Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[soundgasm] add 'sound' and 'user' extractors #3388

Closed
wants to merge 1 commit into from

Conversation

enduser420
Copy link
Contributor

closes #3384

$ gdl --no-download -v https://www.reddit.com/r/AudioCandy/comments/3z0a47/f_soap_by_melanie_martinez_cover/
[gallery-dl][debug] Version 1.24.2-dev - Git HEAD: bcefbfc5
[gallery-dl][debug] Python 3.10.5 - Windows-10-10.0.19045-SP0
[gallery-dl][debug] requests 2.28.1 - urllib3 1.26.13
[gallery-dl][debug] Configuration Files ['%APPDATA%\\gallery-dl\\config.json']
[gallery-dl][debug] Starting DownloadJob for 'https://www.reddit.com/r/AudioCandy/comments/3z0a47/f_soap_by_melanie_martinez_cover/'
[reddit][debug] Using RedditSubmissionExtractor for 'https://www.reddit.com/r/AudioCandy/comments/3z0a47/f_soap_by_melanie_martinez_cover/'
[urllib3.connectionpool][debug] Starting new HTTPS connection (1): oauth.reddit.com:443
[urllib3.connectionpool][debug] https://oauth.reddit.com:443 "GET /comments/3z0a47/.json?limit=0&raw_json=1 HTTP/1.1" 200 3198
[soundgasm][debug] Using SoundgasmSoundExtractor for 'https://soundgasm.net/u/fierce-aphrodite/Soap-by-Melanie-Martinez-Cover'
[urllib3.connectionpool][debug] Starting new HTTPS connection (1): soundgasm.net:443
[urllib3.connectionpool][debug] https://soundgasm.net:443 "GET /user/fierce-aphrodite/Soap-by-Melanie-Martinez-Cover HTTP/1.1" 200 None
* .\gallery-dl\soundgasm\fierce-aphrodite\Soap by Melanie Martinez (Cover).m4a

"description": text.unescape(text.remove_html(text.extr(
page, 'class="jp-description">', "</div>"))),
}
url = text.extract(page, ': "', '"', page.index('("setMedia",'))[0]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url = text.extract(page, ': "', '"', page.index('("setMedia",'))[0]
url = text.extr(page, 'm4a: "', '"')

should i do this?
I don't know if there can be a different ext all the links I came across had m4a in this snippet

$(this).jPlayer("setMedia", {
    m4a: "https://media.soundgasm.net/sounds/04614d5a142ee4d56967ed2b764de3453d048c5b.m4a"
});

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this would obviously break for any other ext, so I had solved this by extracting all potential formats and just picking the first one.

mikf added a commit that referenced this pull request Dec 12, 2022
@enduser420 enduser420 closed this Dec 12, 2022
@enduser420 enduser420 deleted the extractor/soundgasm branch December 12, 2022 12:12
@mikf
Copy link
Owner

mikf commented Dec 12, 2022

Sorry about this and thank you. I've already had the code written and committed on Friday (but not pushed) and didn't want to just throw it away.

mikf added a commit that referenced this pull request Dec 15, 2022
- fix typo (#3399)
- remove double assignment
- [bunkr] update things I forgot in 6b6f886
- [soundgasm] adjust 'archive_fmt' (#3388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST] soundgasm.net support
2 participants