Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dash_url for reddit_video to fix issue 3258 #3306

Merged
merged 3 commits into from
Nov 27, 2022
Merged

use dash_url for reddit_video to fix issue 3258 #3306

merged 3 commits into from
Nov 27, 2022

Conversation

InterruptSpeed
Copy link
Contributor

resolves #3258

syntax is slightly awkward due to flake8 E501 constraints but it works just fine

@InterruptSpeed InterruptSpeed changed the title use fallback_url for reddit_video to fix issue 3258 use dash_url for reddit_video to fix issue 3258 Nov 26, 2022
- use [] instead of .get
- catch TypeErrors in case one of the elements is not a dict
@mikf mikf merged commit a7c7953 into mikf:master Nov 27, 2022
@mikf
Copy link
Owner

mikf commented Nov 27, 2022

Thank you.

syntax is slightly awkward due to flake8 E501 constraints but it works just fine

Yeah, that's sometimes a problem, but usually only for really long functions that should ideally be split into smaller chunks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants