Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hitomi] applying avif check for every image (#3030) #3280

Merged
merged 3 commits into from
Nov 27, 2022

Conversation

styler00dollar
Copy link
Contributor

A webp fallback was introduced after I made aware of it in a github issue, but it does not check every image. As an example, an image sequence like avif, webp, avif, webp, webp, avif, would download incorrectly, or rather, skip all webp due to broken links. The first image is avif, it passes and then tries to download everything as avif, but avif does not exist for every image. An avif property check for every image is needed, since not all files have the same file format in one gallery.

@styler00dollar
Copy link
Contributor Author

I did not notice that i need to check formatting with flake8.

styler00dollar and others added 2 commits November 21, 2022 15:03
- introduce 'path' variable
- only check format availability if not webp
@mikf mikf merged commit a6305d0 into mikf:master Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants