Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nana] add nana extractor #2967

Merged
merged 4 commits into from
Oct 4, 2022
Merged

[nana] add nana extractor #2967

merged 4 commits into from
Oct 4, 2022

Conversation

enduser420
Copy link
Contributor

@enduser420
Copy link
Contributor Author

@mikf have you looked at this?

mikf
mikf reviewed Oct 3, 2022
View reviewed changes
Copy link
Owner

@mikf mikf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay ...

Looking good in general, except the one thing in metadata().
Everything else is not all that important.

docs/gallery-dl-example.conf Outdated Show resolved Hide resolved
gallery_dl/extractor/nana.py Show resolved Hide resolved
gallery_dl/extractor/nana.py Outdated Show resolved Hide resolved
gallery_dl/extractor/nana.py Outdated Show resolved Hide resolved
gallery_dl/extractor/nana.py Outdated Show resolved Hide resolved
gallery_dl/extractor/nana.py Outdated Show resolved Hide resolved
docs/configuration.rst Outdated Show resolved Hide resolved
@mikf mikf merged commit f7ba19a into mikf:master Oct 4, 2022
@mikf
Copy link
Owner

mikf commented Oct 4, 2022

Thanks for the PR.

I'll try to also take a look at your other PRs in the next days, but that's what I've been telling myself to do for the last couple of weeks, so no promises ...

@enduser420
Copy link
Contributor Author

2chen should be complete
Jpgchurch instead of calling the ImageExtractor for each image in an album I can extract the link directly by modifying the thumb link (the re-use on this site in insane)
Mangaread some of the classes can be removed by modifying the base classes pattern

@enduser420 enduser420 deleted the nana-extractor branch October 4, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikf mikf mikf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enduser420 @mikf