Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter author[name] keyword not working #831

Closed
DallasWhite opened this issue Jun 15, 2020 · 1 comment
Closed

Twitter author[name] keyword not working #831

DallasWhite opened this issue Jun 15, 2020 · 1 comment

Comments

@DallasWhite
Copy link

DallasWhite commented Jun 15, 2020

So I'm trying to have my files named in the following way for Twitter:
"filename": "{author[name]}_{tweet_id}_{num}.{extension}"
However, for a twitter profile, the creator of a tweet shows up as None, while only retweeted tweets give the username like so:

PS C:\Users\ABlack> gallery-dl https://twitter.com/tyson_hesse
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\BBQbee_1271192048775790592_1.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\BBQbee_1271192048775790592_2.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\JordanUhl_1268726049816276993_1.mp4
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\akinecoco987_1268305496517177344_1.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\akinecoco987_1268305496517177344_2.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\akinecoco987_1268305496517177344_3.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\akinecoco987_1268305496517177344_4.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\None_1266926436931129344_1.mp4
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\ava_1266803553080733696_1.mp4
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\Freeyourmindkid_1266756362970656771_1.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\Freeyourmindkid_1266756362970656771_2.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\Freeyourmindkid_1266756362970656771_3.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\None_1266413277950562304_1.mp4
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\seokdana_1266047347760365568_1.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\Struggle_Tweet_1263923918726815745_1.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\swarmingrats_1261815267606159360_1.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\swarmingrats_1261815267606159360_2.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\None_1261810209644670976_1.mp4
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\None_1253462533890928640_1.mp4
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\None_1252402025662316551_1.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\None_1251252277135863808_1.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\None_1247632846375677954_1.jpg

I have tried the user[name] keyword, but that puts the username of the profile on every tweet, INCLUDING retweets, so I can't differentiate the retweets from original posts:

PS C:\Users\ABlack> gallery-dl https://twitter.com/tyson_hesse
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\tyson_hesse_1243340302850461696_1.mp4
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\tyson_hesse_1242322085680037888_1.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\tyson_hesse_1242190967421038592_1.mp4
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\tyson_hesse_1241621881305751553_1.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\tyson_hesse_1241063656504217605_1.mp4
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\tyson_hesse_1239431952983179264_1.png
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\tyson_hesse_1236837141566513152_1.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\tyson_hesse_1236837141566513152_2.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\tyson_hesse_1234894807375331328_1.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\tyson_hesse_1234241691290238976_1.png
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\tyson_hesse_1234202718597611522_1.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\tyson_hesse_1234202718597611522_2.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\tyson_hesse_1234202718597611522_3.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\tyson_hesse_1234202718597611522_4.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\tyson_hesse_1232528966331715584_1.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\tyson_hesse_1230057351832457222_1.jpg
* F:\Scripts\Gallery-dl\twitter\tyson_hesse\tyson_hesse_1228494029614022657_1.mp4

This keyword used to work properly, but I assume that the changes to Twitter may have messed with it.

mikf added a commit that referenced this issue Jun 18, 2020
The idea was to have less metadata clutter for most Tweets were
'author' and 'user' are the same (non-retweets), and only provide
a 'user' field.

The original Tweet author could be gotten with
{author[…]|user[…]}, but basically no one knows about that.
@mikf
Copy link
Owner

mikf commented Jun 18, 2020

The commit message of 3561d10 explains it pretty well, I think.

You can get the result you want with {author[name]|user[name]}, but that's not particularly user-friendly. 3561d10 re-adds author and user fields for all Tweets like it was before the rewrite.

@mikf mikf closed this as completed Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants