Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nozomi] multiple tags issue #646

Closed
Cyarutchiii opened this issue Mar 17, 2020 · 2 comments
Closed

[nozomi] multiple tags issue #646

Cyarutchiii opened this issue Mar 17, 2020 · 2 comments

Comments

@Cyarutchiii
Copy link

I tried downloading images from this link: https://nozomi.la/search.html?q=yuri%20bondage#1
However, for some reason gallery-dl is downloading pictures that are not shown on my site.
This is only the case if you try searching for multiple tags, if you just searched for: "https://nozomi.la/tag/yuri-1.html" for example it would download the exact images shown on the site

@Hrxn
Copy link
Contributor

Hrxn commented Mar 19, 2020

@Cyarutchiii Can you please change the title of this issue? Please include at least something like [nozomi] issue with multiple tag search or something, so that it is immediately obvious what this thing is about.

I've been trying to repro this, and it indeed seems to fetch different images like you said, but I'm not sure, maybe the order is wrong? Well, at the beginning, do you get the same pics from your first example URL as from your second example URL?

Anyway, sorry for "hijacking" this issue @mikf (Well, at least it's the same site/extractor), but while testing around I've found a post with multiple images:
https://nozomi.la/post/24159190.html
But gallery-dl does only download the first picture.

Here's my output:

PS C:\Move\Nozomi> gallery-dl -v --ignore-config 'https://nozomi.la/post/24159190.html'
[gallery-dl][debug] Version 1.13.2
[gallery-dl][debug] Python 3.8.2 - Windows-10-10.0.18362-SP0
[gallery-dl][debug] requests 2.23.0 - urllib3 1.25.8
[gallery-dl][debug] Starting DownloadJob for 'https://nozomi.la/post/24159190.html'
[nozomi][debug] Using NozomiPostExtractor for 'https://nozomi.la/post/24159190.html'
[urllib3.connectionpool][debug] Starting new HTTPS connection (1): j.nozomi.la:443
[urllib3.connectionpool][debug] https://j.nozomi.la:443 "GET /post/0/19/24159190.json HTTP/1.1" 200 630
[urllib3.connectionpool][debug] Starting new HTTPS connection (1): i.nozomi.la:443
[urllib3.connectionpool][debug] https://i.nozomi.la:443 "GET /b/30/902db8424b53dc600f524883886c86d9f8a707fe027da17aa35f3f12841bc30b.png HTTP/1.1" 200 1827457
* .\gallery-dl\nozomi\24159190.png
PS C:\Move\Nozomi>

Another example post with even more images:
https://nozomi.la/post/25588032.html

I've only found posts containing single MP4/WEBM files so far, but this might also apply here.

@Cyarutchiii Cyarutchiii changed the title Wrong Images Issue [nozomi] multiple tags issue Mar 19, 2020
@mikf mikf closed this as completed in 33b42dc Mar 19, 2020
mikf added a commit that referenced this issue Mar 19, 2020
This changes the default filename format as well as archive IDs,
since those assumed that each post would only have one image.
@mikf
Copy link
Owner

mikf commented Mar 19, 2020

Search results are getting sorted, so there should at least be a consistent order for returned images, but it still doesn't correspond exactly 1-to-1 to the order on nozomi.la, but it's close. (33b42dc)

And I've also added support for posts with more than 1 image: 2c3b9e1. I've never seen one of these when implementing the extractors and assumed there could only be one file per post and had to change default file names and archive keys to make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants