Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Are Twitter bookmarks supported? #625

Closed
lihuelworks opened this issue Feb 26, 2020 · 7 comments
Closed

[Question] Are Twitter bookmarks supported? #625

lihuelworks opened this issue Feb 26, 2020 · 7 comments

Comments

@lihuelworks
Copy link

lihuelworks commented Feb 26, 2020

Hi, I wanted to ask if Twitter bookmarks / Saved Tweets were implemented as a download source (https://twitter.com/i/bookmarks), since when I try downloading them, having the password on ${HOME}/.gallery-dl.conf like this:

{
    "extractor": 
    {
        "twitter": 
        {
            "username": "theuser",
            "password": "thepassword",
        },
    },
   
}

...gallery-dl throws this error:

yerba@Jehuty:~/Pictures$ gallery-dl https://twitter.com/i/bookmarks
[config][warning] Could not parse '/home/yerba/.gallery-dl.conf': Expecting property name enclosed in double quotes: line 8 column 9 (char 145)
[gallery-dl][error] No suitable extractor found for 'https://twitter.com/i/bookmark

Which seems to be a mistake in editing the config file, but launching gallery-dl with user and pass parameters (like below), also gives an error:

@Hrxn
Copy link
Contributor

Hrxn commented Feb 26, 2020

It's not supported yet. You can check for yourself in the file defining the Twitter extractor, that there is no class for Twitter bookmarks present yet, so it returns the No suitable extractor found error.

Also, this warning:

[config][warning] Could not parse '/home/yerba/.gallery-dl.conf': Expecting property name enclosed in double quotes: line 8 column 9 (char 145)

indicates that there is a syntax error in your configuration file at the mentioned position. Config files need to be valid JSON files.

With regard to Twitter bookmarks:
First time I'm hearing about this, to be honest. Is that feature quite new?

@lihuelworks
Copy link
Author

lihuelworks commented Feb 26, 2020

They Twitter blog mentions it's creation in Feb 2018. They are a little bit hidden in the sharing options:

2020-02-26_18-37 2020-02-26_18-38

...but they are incredibly handy, as they are the only way to save a group of tweets that the platform allows (since retweets often get mixed up with a bunch of other stuff, and choosing them as saving mechanism means you can't use them for anything else). Is there a way to help write an extractor for them, or to at least request the feature for future releases?

@mikf
Copy link
Owner

mikf commented Mar 1, 2020

All Twitter extractors are currently relying on Twitter's old interface and internal API, making it basically impossible to add anything new until the whole thing gets re-written to use the new interface. When that happens, I'll also add support for bookmarked Tweets.

@lihuelworks
Copy link
Author

Got it. Thanks Mike, and sorry for the trouble.

@mikf mikf closed this as completed in 32df8d0 Mar 6, 2020
@mikf
Copy link
Owner

mikf commented Mar 6, 2020

I've taken a look at some other Twitter bookmark projects and managed to come up with a "working" solution. It's not particularly efficient, but it should do its job (or at least it worked when I tested this with my account)

@lihuelworks
Copy link
Author

I've taken a look at some other Twitter bookmark projects and managed to come up with a "working" solution. It's not particularly efficient, but it should do its job (or at least it worked when I tested this with my account)

Thanks for putting the effort Mikf, appreciate it. Is the future coming in a future release or is for testing only?

@mikf
Copy link
Owner

mikf commented Mar 21, 2020

It is included in the latest version (1.13.2, changelog)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants