Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site Request] koharu.to #5893

Closed
K0ng2 opened this issue Jul 26, 2024 · 6 comments
Closed

[Site Request] koharu.to #5893

K0ng2 opened this issue Jul 26, 2024 · 6 comments

Comments

@K0ng2
Copy link

K0ng2 commented Jul 26, 2024

extractor support for koharu.to

@a84r7a3rga76fg
Copy link

Same site as #4707

@mikf
Copy link
Owner

mikf commented Jul 28, 2024

I've added initial support for this site: c9aeede

It can currently do single galleries and search results. The download format can be selected with the cbz and format options.

Is there anything else that should be added? I'm guessing favorites. tags need to be cleaned up as well.

@a84r7a3rga76fg
Copy link

"cbz": false causes no file to be downloaded and the message '400 Bad Request'

@mikf
Copy link
Owner

mikf commented Aug 1, 2024

"cbz": false causes no file to be downloaded and the message '400 Bad Request'

Fixed in ff58683.

Downloading favorites and login got implemented in c372242.

@mikf mikf closed this as completed Aug 1, 2024
@a84r7a3rga76fg
Copy link

a84r7a3rga76fg commented Aug 1, 2024

Could the gallery count be added to the metadata file when using "cbz": true?

How does Koharu calculate gallery size? Extracting the images from the downloadable CBZ file or after downloading the images with "cbz": false never matches the gallery size on Koharu.

Image files in the downloadable CBZ file and from "cbz": false always have different hashes but the same pixel amount (according to Imagemagick).

gallery-dl.png PNG 1360x1920 1360x1920+0+0 8-bit TrueColor sRGB 2.1397MiB 0.059u 0:00.059
cbz.png PNG 1360x1920 1360x1920+0+0 8-bit TrueColor sRGB 2.1397MiB 0.053u 0:00.052
Image: 1.png
  Channel distortion: AE
    red: 0
    green: 0
    blue: 0
    all: 0
1.png=>dif.png PNG 1360x1920 8-bit sRGB 2.1397MiB 0.710u 0:00.709

@mikf
Copy link
Owner

mikf commented Aug 3, 2024

Could the gallery count be added to the metadata file when using "cbz": true?

9be7896

How does Koharu calculate gallery size? Extracting the images from the downloadable CBZ file or after downloading the images with "cbz": false never matches the gallery size on Koharu.

Sorry, but I have no idea either.

i can confirm that the size reported by koharu doesn't match the cbz archive or individual images.

Image files in the downloadable CBZ file and from "cbz": false always have different hashes but the same pixel amount (according to Imagemagick).

They even have the same pixel values. Both file versions are almost identical except for two extra bytes at the end of each non-cbz file:

diff --git a/cbz b/file
index 79af316..e1499c3 100644
--- a/cbz
+++ b/file
@@ -37928,3 +37928,4 @@
 00094270: c6f0 3ae5 e9ed da18 4d71 1444 1436 79c9  ..:.....Mq.D.6y.
 00094280: a4a5 fdff ed50 df7a ebad ff03 d8e2 5de4  .....P.z......].
 00094290: d0fc 3c12 0000 0000 4945 4e44 ae42 6082  ..<.....IEND.B`.
+000942a0: 534e                                     SN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants