Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential DeviantArt bug? #455

Closed
Twi-Hard opened this issue Oct 22, 2019 · 7 comments
Closed

Potential DeviantArt bug? #455

Twi-Hard opened this issue Oct 22, 2019 · 7 comments

Comments

@Twi-Hard
Copy link

If the downloader comes across a deviantart URL of an account that had a name change it often only downloads 1 image. Out of the 98 deviant folders so far that were from a redirect, 39 folders have only one image, 7 folders have two images and 3 folders have three images. Most of the other accounts downloaded fine. All the deviants that didn't have a name change downloaded correctly it seems. I checked a few accounts that were from redirects that downloaded only 1 image and they had a lot of images online.
The average amount of images downloaded per account otherwise is ~223 images.
Trying to download the accounts with their current name downloads everything.
I don't know which of the original URLs were for the accounts that only downloaded 1 image.
I can rerun the downloader with the new names so this doesn't affect me too much but I thought it would be good to mention it.

mikf added a commit that referenced this issue Oct 26, 2019
In the case that a user changed his username, requesting deviations
with an old name might cause problems (missing deviations, etc.)

The internal 'username' value therefore now gets updated to the
current username taken from the user profile.
@mikf
Copy link
Owner

mikf commented Oct 26, 2019

The code will now always use current usernames when listing deviations, since the old names appear to cause problems.

I've tried to reproduce your problem with 3 accounts that changed their names at some point before attempting to fix this, but they worked as they should with both new and old name, so hopefully using their current names actually does something ...

Another possibility would be private deviations that can only be accessed when being logged in or using a refresh-token, but you'd have gotten a warning message in that case.

@mikf mikf closed this as completed Oct 26, 2019
@Twi-Hard
Copy link
Author

Twi-Hard commented Nov 16, 2019

It seems the fix you did reverted somehow. Gallery-dl is back to using the lowercase names in the current dev release (1.11.2-dev). When you did that fix the capitalization for all the artists was correct. Now it seems things are back to how they were?

@Hrxn
Copy link
Contributor

Hrxn commented Nov 16, 2019

So, you are saying that it's working as supposed with version v1.11.1?

@Twi-Hard
Copy link
Author

Ok, I went back and checked the recent versions. It works properly in v1.11.0 but it went back to how it was in version v1.11.1

@Twi-Hard
Copy link
Author

Twi-Hard commented Nov 18, 2019

Ok, I'm really confused. Now I can't get any version of gallery-dl to capitalize folder names with either EXEs or python. I tested it with the EXEs yesterday when I got v1.11.0 to work. I've tried for hours now. I've tried with and without configs. I wasn't using a config yesterday when it worked.

mikf added a commit that referenced this issue Nov 18, 2019
The 'username' field was capitalized in a very inconsistent manner:
Either all lowercase, or as given by the input URL, or with the
"original" capitalization, depending on the extractor used among
other things.

Now usernames use their original capitalization for all extractors.
('UserName' instead of 'username' or 'uSeRnAmE')
@mikf
Copy link
Owner

mikf commented Nov 18, 2019

There haven't been any changes to usernames and their capitalization for a long time except maybe 9e3a860. The general problem was username capitalization being all over the place across different extractor classes, but that should be fixed in 9fdc5e7.

@Twi-Hard
Copy link
Author

It worked! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants