Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extractor.reddit.comments needs to be set to 1 instead of 0 to ignore comments #429

Closed
kattjevfel opened this issue Sep 26, 2019 · 4 comments
Labels

Comments

@kattjevfel
Copy link
Contributor

From the documentation:

The value 0 ignores all comments and significantly reduces the time required when scanning a subreddit.

This took me way too long to figure out (I blame that it's past midnight), but with it set to 0 it will just download all comments as if I had not set it.
Setting it to 1 has the desired effect (only getting the actual post)

set to 0
set to 1

@mikf
Copy link
Owner

mikf commented Sep 27, 2019

This is one of the occasions were the value-type really matters. It needs to be the number 0 (or anything that evaluates to False in Python) and not the string "0". But you are right, the documentation on that one is inconsistent. Thanks for pointing that out.

@mikf mikf closed this as completed in 46ba173 Sep 27, 2019
@kattjevfel
Copy link
Contributor Author

Even with 803d8f8 the behavior stays unchanged for me, doesn't matter if I set it to "comments": "0", or "comments": 0,, it just downloads all comments.

Setting it to "comments": "1", or "comments": 1, works for me, but someone else might run into the same headache in the future.

@mikf mikf reopened this Sep 27, 2019
@kattjevfel
Copy link
Contributor Author

It seems to be working when downloading from a page (like saved posts), but when doing a post directly it just downloads all images.

You can test it yourself with https://www.reddit.com/r/Animemes/comments/d9ie4r/weebs_hmmmmm/

@mikf
Copy link
Owner

mikf commented Sep 28, 2019

It should now also work for individual submissions and not just entire subreddits or other listings.

@mikf mikf closed this as completed Sep 28, 2019
@mikf mikf added the bug label Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants