Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site support request: Plurk #212

Closed
brlin-tw opened this issue Apr 4, 2019 · 4 comments
Closed

Site support request: Plurk #212

brlin-tw opened this issue Apr 4, 2019 · 4 comments

Comments

@brlin-tw
Copy link
Contributor

brlin-tw commented Apr 4, 2019

All pictures in a post. Example: https://www.plurk.com/p/i701j1

There are also pictures in the replies, but are lazily loaded via AJAX-like.

@mikf
Copy link
Owner

mikf commented Apr 14, 2019

Initial support for Plurk is done. (0b2ff40)

It works by scanning a Plurk's content for URLs and forwarding them to other extractors, similar to how Reddit extractors do their job. You can enable the comments option (70be494) to also search those for URLs.

@brlin-tw
Copy link
Contributor Author

brlin-tw commented Apr 15, 2019

I've tried the latest snapshot(1.8.2-2-g70be494) using the aforementioned example URL, however, it seems that the pictures in the comment section are also downloaded even I don't have the extractor.plurk.comments config set at all.

Can you check it out?

@mikf
Copy link
Owner

mikf commented Apr 15, 2019

That particular post contains 3 hyperlinks by itself, one of them being an Imgur album with all pictures already in it:

$ gallery-dl -g https://www.plurk.com/p/i701j1
https://4.bp.blogspot.com/-HPXVpK9ukb4/USX0700w-uI/AAAAAAAALok/7MSx8yVhR7M/s1600/18_GWTB6.jpg
http://www.plurk.com/emilwu
https://imgur.com/a/Y8YFV

The blogspot link gets downloaded directly, the plurk link is ignored to prevent infinite recursion, and the imgur link gets forwarded to the respective imgur extractor.

Enabling extractor.plurk.comments would get more than 200 URLs (see unit tests).

@brlin-tw
Copy link
Contributor Author

Oh, I see, thanks for the explanation!

I suppose this issue can be closed now, thank you so much for implementing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants