Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Using Github Actions to compile gallery-dl upon commit #1312

Closed
God-damnit-all opened this issue Feb 12, 2021 · 11 comments
Closed

Comments

@God-damnit-all
Copy link
Contributor

The cloudflare issue is still at large, and I've been having an issue very unique to my setup in which anti-cheat does not like repeated python executions in the background, but it doesn't seem to mind the gallery-dl executable.

There's not really a guide on compiling gallery-dl to an executable posted, but rather than ask for that, I think it'd be simpler in the long run just to have Github compile it every time there's a new commit. Would you be willing?

@Hrxn
Copy link
Contributor

Hrxn commented Feb 14, 2021

I don't really understand what you are trying to say here, to be honest. Anti-cheat? In the background?

If you are concerned about false positives, you should probably avoid the bundled executable and simply install Python instead on your system to run gallery-dl. I've never heard about any issues if you do it that way, I think.

@God-damnit-all
Copy link
Contributor Author

I don't really understand what you are trying to say here, to be honest. Anti-cheat? In the background?

If you are concerned about false positives, you should probably avoid the bundled executable and simply install Python instead on your system to run gallery-dl. I've never heard about any issues if you do it that way, I think.

I'm having the opposite problems where it doesn't like python but doesn't mind the bundled executable.

@rautamiekka
Copy link
Contributor

I don't really understand what you are trying to say here, to be honest. Anti-cheat? In the background?
If you are concerned about false positives, you should probably avoid the bundled executable and simply install Python instead on your system to run gallery-dl. I've never heard about any issues if you do it that way, I think.

I'm having the opposite problems where it doesn't like python but doesn't mind the bundled executable.

Give the commands used and the resulting outputs/logs.

@God-damnit-all
Copy link
Contributor Author

God-damnit-all commented Feb 16, 2021

I don't really understand what you are trying to say here, to be honest. Anti-cheat? In the background?
If you are concerned about false positives, you should probably avoid the bundled executable and simply install Python instead on your system to run gallery-dl. I've never heard about any issues if you do it that way, I think.

I'm having the opposite problems where it doesn't like python but doesn't mind the bundled executable.

Give the commands used and the resulting outputs/logs.

It's a bluescreen. Happens consistently but at somewhat random, generally about half an hour to an hour of scraping twitter.

There's not much that can be done about it, really.

@Hrxn
Copy link
Contributor

Hrxn commented Feb 17, 2021

A real bluescreen?

Then it's very likely some deeper issue with your system, normal userspace programs cannot cause this in usual circumstances.

@God-damnit-all
Copy link
Contributor Author

A real bluescreen?

Then it's very likely some deeper issue with your system, normal userspace programs cannot cause this in usual circumstances.

Ring-0 anti-cheat programs do some unpredictable things.

@Hrxn
Copy link
Contributor

Hrxn commented Feb 17, 2021

I'm aware, so you should better explain why this is an issue with gallery-dl

@God-damnit-all
Copy link
Contributor Author

God-damnit-all commented Feb 17, 2021

I'm aware, so you should better explain why this is an issue with gallery-dl

It's not. It's just one of the reasons why I would like this feature. I did not submit this as a bug.

@God-damnit-all
Copy link
Contributor Author

I'm just going to close this and resubmit the request at a later date without mentioning the anti-cheat problems I've been having.

mikf added a commit that referenced this issue Feb 17, 2021
@mikf
Copy link
Owner

mikf commented Feb 17, 2021

So I tried something and it actually seems to work:
https://github.com/mikf/gallery-dl/actions/runs/575031865#artifacts

The Windows executable has actually less positives on VirusTotal than my own builds:
https://www.virustotal.com/gui/file/e728f79d112e9d4ecd40ff2475185fb17b2f51cf96a08edfff047f48a9fad139/detection

There's not really a guide on compiling gallery-dl to an executable posted

  • set up and activate a virtualenv
  • pip install requests urllib3==1.25.11 youtube-dl pyinstaller
  • run ./scripts/pyinstaller.py

@Hrxn
Copy link
Contributor

Hrxn commented Feb 18, 2021

Less false positives? I wonder how, honestly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants