Detekt #786
Detekt #786
Conversation
* enable detekt on travis
| @@ -10,7 +10,7 @@ buildscript { | |||
| compileSdk: 29, | |||
| buildTools: "29.0.0", | |||
| minSdk : 14, | |||
| targetSdk : 29 | |||
| targetSdk : 28 | |||
There was a problem hiding this comment.
Why was this reverted to 28?
There was a problem hiding this comment.
roboelectric does not support 29 yet :/
| } | ||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:3.4.1' | ||
| classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:${versions.kotlin}" | ||
| classpath 'com.github.dcendents:android-maven-gradle-plugin:2.1' | ||
| classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.8.4' | ||
| classpath "io.gitlab.arturbosch.detekt:detekt-gradle-plugin:1.0.0-RC15" |
There was a problem hiding this comment.
Might want to put version within ext.versions since it occurs in 3 places
There was a problem hiding this comment.
yes true. I will do that.
|
Does the formatter actually work? The detekt command itself just seems to label some warnings. It might take |
|
I tried locally with wrong indents and it failed the build, so it should fail the travis build too when the wrong indents are used for example. the idea stuff requires IDEA with the format.sh script which is not available on travis it will not modify anything |
|
Weird. For #788 it doesn't fail to build, even if I move some indents around |
|
@AllanWang I checked. The problem was that we were within the 10 warnings threshold per module which was ok. I set it now to 0 and fixed all the remaining warnings and adjusted others |
Alternative to spotless. Replacing #785