Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for js in compose module #937

Closed
wants to merge 3 commits into from

Conversation

DRSchlaubi
Copy link
Contributor

No description provided.

@mikepenz
Copy link
Owner

Thank you very much for the PR.

We already have an experimental wasm based build available, which you can find here: https://github.com/mikepenz/AboutLibraries/releases/tag/v10.9.2-wasm1

@mikepenz
Copy link
Owner

With wasm now being available in more dependencies. wasm support was merged: #940

@DRSchlaubi
Copy link
Contributor Author

I need a JS build however

@mikepenz
Copy link
Owner

@DRSchlaubi I am not sure how that would work, compose for js target without wasm. can you link me to the documentation explaining this?

The core module already has a js target which allows you to build any visualisation you would like: https://github.com/mikepenz/AboutLibraries/blob/develop/aboutlibraries-core/build.gradle.kts#L118

@DRSchlaubi
Copy link
Contributor Author

It works exactly how I prred it, you just add the js target and add the canvas flag

could not find any specific documentation, except for the wasm sample

Copy link
Owner

@mikepenz mikepenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this PR on the latest develop branch. Happy to do a new release with js added if it just works like that.

@mikepenz
Copy link
Owner

Merged into dev (did a rebase for clean history, thus the auto close didn't function)
77469d9

@mikepenz mikepenz closed this Dec 18, 2023
@mikepenz
Copy link
Owner

In the process now to release 10.10.0-rc02

@mikepenz
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants