-
-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for js in compose module #937
Conversation
Thank you very much for the PR. We already have an experimental wasm based build available, which you can find here: https://github.com/mikepenz/AboutLibraries/releases/tag/v10.9.2-wasm1 |
With wasm now being available in more dependencies. wasm support was merged: #940 |
I need a JS build however |
@DRSchlaubi I am not sure how that would work, compose for js target without wasm. can you link me to the documentation explaining this? The |
It works exactly how I prred it, you just add the js target and add the canvas flag could not find any specific documentation, except for the wasm sample |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase this PR on the latest develop branch. Happy to do a new release with js
added if it just works like that.
Merged into dev (did a rebase for clean history, thus the auto close didn't function) |
In the process now to release 10.10.0-rc02 |
looks sonatype has some issues at this time: https://github.com/mikepenz/AboutLibraries/actions/runs/7252679539/job/19757656507#step:11:155 |
No description provided.