Allow changing typography in the compose module #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using import androidx.compose.material3 and ProGuard, I was receiving this error:
```
java.lang.NoClassDefFoundError: Failed resolution of: Landroidx/compose/material/MaterialTheme;
at com.mikepenz.aboutlibraries.ui.compose.SharedLibrariesKt.Library(Unknown Source:95)
```
By making this a parameter, I can override it from my code so that androidx.compose.material.MaterialTheme is never accessed. I did try adding keep rules to R8 but it doesn't seem to fix the issue. Since there is not even any reflection, I don't know why it's broken in the first place.
mikepenz
approved these changes
Jan 25, 2023
|
Thank you very much for the PR and improvement. |
mikepenz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using import androidx.compose.material3 and ProGuard, I was receiving this error:
By making this a parameter, I can override it from my code so that androidx.compose.material.MaterialTheme is never accessed. I did try adding keep rules to R8 but it doesn't seem to fix the issue. Since there is not even any reflection, I don't know why it's broken in the first place.
(sorry about the added newline at the EOF, silly github web added it)