[V10] Prototype next generation Kotlin Multiplatform AboutLibraries #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry or loaded from spdx (if not found in project) - tries to find LICENSE file in the open source repository using standard directories - introduce new JSON storage format, not resulting in resource identifiers created (unless for licenses which could not be found via URL) - introduce new settings to enable the remote license loading / or the new json storage format
- update kotlin
- drop support for writing the xml resource files - temporarily disable support for SPDXLicense detection - fully use information provided via `pom.xml` -> and alternative the repo license
…d in gradle, using the ivy dependency - drop support for legacy mapping files - adjust storage format for new json definition
- define core module as kotlin multiplatform and setup proper definition parsing - include licenses in single json file for a more consistent parsing behavior - enhanced library license merging - use new core library within aboutlibraries
…android projects - introduce jvm parser logic - use github API to retrieve license information from a repo (note this is rate limited!)
- introduce API to provide github token for GitHub API license retrieval - cleanup and simplify
- do a check run to verify merged library information did not include spdx licenses potentially missing - remove old legacy code - remove support for include all licenses (if anticipated, needed licenses can be listed)
- update gradle
- use theme text appearance to better adjust based on the app theme
- remove support to use library without licenses - drop more legacy APIs adding a lot of overhead - drop coroutine dependency from core module
…icenses are used in the project - enhance javadoc for extension - a bit of cleanup for different classes
- add tmp experimental compose source - update ci to handle new multiplatform module
- initial Compose list variant - add compose sample activity to sample app
- make github token optional - simplify plugin setup
This was referenced Oct 31, 2021
Closed
- compose 1.1.0-beta02 - accompanist 0.21.2-beta - materialdrawer 9.0.0-a02 - drop detekt for now
…tlibs.json` independent of android - generates the file in the modules build folder - configure different target folder via `exportPath` property - configure preferred variant via `exportVariant` property - improve input/output spec for different targets
mikepenz
force-pushed
the
feature/remote_licenses
branch
from
40d30f1 to
15c1b16
Compare
…led (to potentially better handle different usecases)
- plugin kotlin 1.6.0 - plugin publish 0.18.0 - compose 1.1.0-beta03 - constraintLayout 2.1.2 - compose-jb beta6-dev464
mikepenz
force-pushed
the
feature/remote_licenses
branch
from
6fb33e9 to
d0d07fe
Compare
G8342
approved these changes
Nov 20, 2021
mikepenz
force-pushed
the
feature/remote_licenses
branch
from
92c993c to
7a7e4f2
Compare
mikepenz
force-pushed
the
feature/remote_licenses
branch
from
7a7e4f2 to
7940801
Compare
…iplatform support)
mikepenz
force-pushed
the
feature/remote_licenses
branch
3 times, most recently
from
e891600 to
238cd39
Compare
mikepenz
force-pushed
the
feature/remote_licenses
branch
from
238cd39 to
14dbd6b
Compare
|
This looks awesome Mike, thanks for all your hard work! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial new version of the
pluginintroducing a new storage format, and improved performance.New storage format includes multiple developer specifications, multiple licenses, and automatic download of LICENSE information as stored in the related open source GitHub repository (optional)
Optionally provide GitHub read only PAT for the
GitHub license API.New
strictModeallowing to only succeed the build if all dependencies match the allowed libraries. E.g. only allow libraries withApache-2.0orMITlicenses, ...New
coremodule, fully refactored and redone as Kotlin Multiplatform module. Initial version supports JVM and Android. (JVM using kotlinx-serialization to parse the library detail information)Worked through
aboutlibrariesmodule (old UI module) and cleanup code and drop rarely used APIs only introducing overhead.Initial new compose module with a new simplified UI, and great base code to write custom compose UIs visualising dependencies and libraries used within a project.
TODO: