Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hamcrest BSC License 3 not detected #639

Closed
2 tasks done
carstenhag opened this issue May 14, 2021 · 2 comments · Fixed by #642
Closed
2 tasks done

Hamcrest BSC License 3 not detected #639

carstenhag opened this issue May 14, 2021 · 2 comments · Fixed by #642
Assignees
@mikepenz
Labels
feature

Comments

@carstenhag
Copy link

About this issue

  • Briefly describe the issue

exportLibraries says:

UNKNOWN LICENSES:
BSD License 3
-- [org.hamcrest:hamcrest:2.2]
  • How can the issue be reproduced / sample code

Import testImplementation "org.hamcrest:hamcrest:2.2"

Details

  •  Used library version: 8.8.5

Checklist
@mikepenz
Copy link
Owner

This one is not matched because that lib does not use the specific spdx identifier. BSD-3-Clause

As this seems to be more common though, will expand the matching to the license url

@mikepenz mikepenz self-assigned this May 16, 2021
mikepenz added a commit that referenced this issue May 16, 2021
@mikepenz
- expand BSD-3-Clause matching
0449a60 
  - FIX #639
@mikepenz mikepenz mentioned this issue May 16, 2021
Merged
@carstenhag
Copy link
Author

Thanks! Yeah, I figured that the bsd ones sometimes have different names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikepenz mikepenz

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve BSD-3-Clause matching mikepenz/AboutLibraries
2 participants
@mikepenz @carstenhag