-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🐛 Fix reflow occuring unexpectedly in body
Reflow when entering text in the body was inconsistent. The following test case shows the issue (has padding of 1 on both sides): +------------+ | 1234567890 | | 1 2 3 4 5 | | 6 | +------------+ The 10th character on the second line should be 6 however as there is a space it is immediately reflowed to the next line. The cursor never being allowed in the 11th character position creates this edge case. This bug has further details in the GitHub issue: charmbracelet/bubbles#333 The textarea width is set to 72 characters however any line with a space contained in it will reflow at 71 characters. To workaround this issue reflow has been set to 71 characters. Test cases have been added to detect this problem.
- Loading branch information
1 parent
8efac8f
commit 3e57285
Showing
5 changed files
with
71 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
|
||
┌──────────────────────────────────────────────────────────────────────────┐ | ||
│ 1234567890 │ | ||
│ 1 2 3 4 │ | ||
│ 56 │ | ||
└──────────────────────────────────────────────────────────────────────────┘ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
|
||
┌──────────────────────────────────────────────────────────────────────────┐ | ||
│ 1 2 3 4 │ | ||
│ 56 │ | ||
│ │ | ||
└──────────────────────────────────────────────────────────────────────────┘ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
|
||
┌──────────────────────────────────────────────────────────────────────────┐ | ||
│ 1234567890 │ | ||
│ │ | ||
│ │ | ||
└──────────────────────────────────────────────────────────────────────────┘ |