Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code had several issues with existing IMAP UID search:
nil
when the server returns nothing. (>= v0.4 returns an empty array when the server returns nothing.)SearchResult
.SearchResult
inherits fromArray
, but because it's frozen, mutating it withreverse!
results in an exception. See Frozen SearchResult breaks IMAP.find with what: :last option ruby/net-imap#262. (v0.4.10 and above doesn't freeze SearchResult.)ESEARCH
results, but those will be returned as anESearchResult
struct (probably frozen).IMAP4rev1
servers shouldn't returnESEARCH
unless the client has activated that extension, butIMAP4rev2
servers will always returnESEARCH
.UID SEARCH
. Almost all servers do return sorted UIDs, most of the time. But it isn't 100% reliable.The fix is simple:
#to_a
to convert bothnil
andESearchResult
into an array of UIDs.#sort
to ensure the UIDs are sorted. This also returns a new array, without mutating the original (which may be frozen).