Incorrect file permissions in 2.8.0

[CvX]

Some files in 2.8.0.rc1 release are not world-readable: (notice elements.rb, fields.rb, indifferent_hash.rb)

-rw-r--r--@  1 cvx  staff   3481 Apr 22 02:41 attachments_list.rb
-rw-r--r--@  1 cvx  staff   9545 Apr 22 02:41 body.rb
-rw-r--r--@  1 cvx  staff   1781 Apr 22 02:41 configuration.rb
-rw-r--r--@  1 cvx  staff   2472 Apr 22 02:41 constants.rb
drwxr-xr-x  14 cvx  staff    448 May 17 16:51 elements
-rw-r-----@  1 cvx  staff    960 Apr 22 02:41 elements.rb
drwxr-xr-x  10 cvx  staff    320 May 17 16:51 encodings
-rw-r--r--@  1 cvx  staff   9792 Apr 22 02:41 encodings.rb
-rw-r--r--@  1 cvx  staff    573 Apr 22 02:41 envelope.rb
-rw-r--r--@  1 cvx  staff   8885 Apr 22 02:41 field.rb
-rw-r--r--@  1 cvx  staff   2077 Apr 22 02:41 field_list.rb
drwxr-xr-x  41 cvx  staff   1312 May 17 16:51 fields
-rw-r-----@  1 cvx  staff   2244 Apr 22 02:41 fields.rb
-rw-r--r--@  1 cvx  staff   7528 Apr 22 02:41 header.rb
-rw-r-----@  1 cvx  staff   3874 Apr 22 02:41 indifferent_hash.rb
-rw-r--r--@  1 cvx  staff   8346 Apr 22 02:41 mail.rb
drwxr-xr-x   4 cvx  staff    128 May 17 16:51 matchers
-rw-r--r--@  1 cvx  staff  67251 Apr 22 02:41 message.rb
drwxr-xr-x   5 cvx  staff    160 May 17 16:51 multibyte
-rw-r--r--@  1 cvx  staff   3563 Apr 22 02:41 multibyte.rb
drwxr-xr-x   4 cvx  staff    128 May 17 16:51 network
-rw-r--r--@  1 cvx  staff    836 Apr 22 02:41 network.rb
-rw-r--r--@  1 cvx  staff    446 Apr 22 02:41 parser_tools.rb
drwxr-xr-x  34 cvx  staff   1088 May 17 16:51 parsers
-rw-r--r--@  1 cvx  staff    522 Apr 22 02:41 parsers.rb
-rw-r--r--@  1 cvx  staff   3124 Apr 22 02:41 part.rb
-rw-r--r--@  1 cvx  staff   3374 Apr 22 02:41 parts_list.rb
-rw-r--r--@  1 cvx  staff   1410 Apr 22 02:41 smtp_envelope.rb
-rw-r--r--@  1 cvx  staff  16176 Apr 22 02:41 utilities.rb
drwxr-xr-x   3 cvx  staff     96 May 17 16:51 values
-rw-r--r--@  1 cvx  staff    235 Apr 22 02:41 version.rb
-rw-r--r--@  1 cvx  staff    655 Apr 22 02:41 yaml.rb

This wasn't the case in previous releases:

# 2.7.1
-rw-r--r--@  1 cvx  staff   3590 Oct 13  2018 attachments_list.rb
-rw-r--r--@  1 cvx  staff   9745 Oct 13  2018 body.rb
-rw-r--r--@  1 cvx  staff   1461 Oct 13  2018 check_delivery_params.rb
-rw-r--r--@  1 cvx  staff   1781 Oct 13  2018 configuration.rb
-rw-r--r--@  1 cvx  staff   1792 Oct 13  2018 constants.rb
drwxr-xr-x   4 cvx  staff    128 May 17 16:39 core_extensions
drwxr-xr-x  14 cvx  staff    448 May 17 16:39 elements
-rw-r--r--@  1 cvx  staff    960 Oct 13  2018 elements.rb
drwxr-xr-x  10 cvx  staff    320 May 17 16:39 encodings
-rw-r--r--@  1 cvx  staff  10711 Oct 13  2018 encodings.rb
-rw-r--r--@  1 cvx  staff    658 Oct 13  2018 envelope.rb
-rw-r--r--@  1 cvx  staff   9511 Oct 13  2018 field.rb
-rw-r--r--@  1 cvx  staff    867 Oct 13  2018 field_list.rb
drwxr-xr-x  35 cvx  staff   1120 May 17 16:39 fields
-rw-r--r--@  1 cvx  staff   2244 Oct 13  2018 fields.rb
-rw-r--r--@  1 cvx  staff   9235 Oct 13  2018 header.rb
-rw-r--r--@  1 cvx  staff   3874 Oct 13  2018 indifferent_hash.rb
-rw-r--r--@  1 cvx  staff   8346 Oct 13  2018 mail.rb
drwxr-xr-x   4 cvx  staff    128 May 17 16:39 matchers
-rw-r--r--@  1 cvx  staff  68178 Oct 13  2018 message.rb
drwxr-xr-x   5 cvx  staff    160 May 17 16:39 multibyte
-rw-r--r--@  1 cvx  staff   3766 Oct 13  2018 multibyte.rb
drwxr-xr-x   4 cvx  staff    128 May 17 16:39 network
-rw-r--r--@  1 cvx  staff    836 Oct 13  2018 network.rb
-rw-r--r--@  1 cvx  staff    446 Oct 13  2018 parser_tools.rb
drwxr-xr-x  34 cvx  staff   1088 May 17 16:39 parsers
-rw-r--r--@  1 cvx  staff    681 Oct 13  2018 parsers.rb
-rw-r--r--@  1 cvx  staff   3230 Oct 13  2018 part.rb
-rw-r--r--@  1 cvx  staff   2003 Oct 13  2018 parts_list.rb
-rw-r--r--@  1 cvx  staff   8570 Oct 13  2018 utilities.rb
drwxr-xr-x   3 cvx  staff     96 May 17 16:39 values
-rw-r--r--@  1 cvx  staff    233 Oct 13  2018 version.rb
drwxr-xr-x   4 cvx  staff    128 May 17 16:39 version_specific

…and makes the gem unusable in some setups:

LoadError: cannot load such file -- /usr/local/lib/ruby/gems/2.7.0/gems/mail-2.8.0.rc1/lib/mail/indifferent_hash.rb

Can you re-release rc1 with corrected permissions as rc2?

[djpate]

Any updates on this?

[meineerde]

With this issue unresolved in the released 2.8.0 gem, the current version of the mail gem is unusable in setups requiring read-access to others (e.g. in cases where the gem is installed by a different user than the one running the application).

Could you possible release a new version of the mail gem to rubygems which fixes the file permissions and set all files to be readable by everyone, similar to all the other files in the gem?

[benlangfeld]

Hey @mikel , I believe this issue merits urgent attention and does not appear to be something that we can contribute to - file permissions in git seem to be correct, and this seems to be something related to how you cut releases that isn't visible to anyone else to assist in fixing it. This was reported prior to 2.8.0 being released and it seems to have been reasonable justification to hold back that release, but it doesn't seem to have stood out in the list of open issues enough for that to happen, which is why I'm trying to call some more direct attention to it here. Thanks for your help and your work on this project :)

[andreynering]

I also checked yesterday and I can confirm permissions are correct in the repository. It's something on the release process that messed with it somehow.

[rmehner]

We've also been bitten by this. We've downgraded to 2.7.1 for now. Another workaround was to fix the permissions ourselves within the docker container. A bit hacky, but works.

[ssunday]

Also having issues, reverting to 2.7.1.

[szymonpk]

If you need to fix permissions after the installation, run find /usr/local/bundle/gems/mail-2.8.0.rc1/ -type f -perm 640 -exec chmod 644 {} \;. Adjust path to the gem if needed.

[sebbASF]

Find non-world readable files:

$ find /var/lib/gems/2.7.0/gems/mail-2.8.0 -not -perm -4 -ls
6148232 4 -rw-r----- 1 root root 1063 Dec 5 20:35 /var/lib/gems/2.7.0/gems/mail-2.8.0/MIT-LICENSE
6148311 4 -rw-r----- 1 root root 3874 Dec 5 20:35 /var/lib/gems/2.7.0/gems/mail-2.8.0/lib/mail/indifferent_hash.rb
6148269 4 -rw-r----- 1 root root 2244 Dec 5 20:35 /var/lib/gems/2.7.0/gems/mail-2.8.0/lib/mail/fields.rb
6148377 980 -rw-r----- 1 root root 1001797 Dec 5 20:35 /var/lib/gems/2.7.0/gems/mail-2.8.0/lib/mail/values/unicode_tables.dat
6148242 4 -rw-r----- 1 root root 960 Dec 5 20:35 /var/lib/gems/2.7.0/gems/mail-2.8.0/lib/mail/elements.rb

The dat file might also be needed by others

[rgaufman]

Had to downgrade to 2.7.1 also :(

[themilkman]

Also run in troubles with this in context of Devise::Mailer. Chmod'ing files helped.

[akilamunasinghe]

We ran into the same issue and I have trouble downgrading as it is a dependency for later versions of actionmailer.