Adjust PHPUnit 5 check to be consistent with others #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with how other versions are checked, and also reduces esoteric bugs when PHPUnit_TextUI_ResultPrinter exists, even though the PHPUnit version is newer.
kostajh
force-pushed
the
phpunit-5-check
branch
from
a7d8930 to
40422d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with how other versions are checked, and also reduces
esoteric bugs when PHPUnit_TextUI_ResultPrinter exists, even though the
PHPUnit version is newer.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[X] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Make check consistent with others.
Which issue (if any) does this pull request address?
Fixes #174
Is there anything you'd like reviewers to focus on?