-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: Scene Transform #2278
Merged
Release: Scene Transform #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function had the docstring from segments_to_parameters, copying documentation from path.Path.fill_gaps instead
Added optional parameter to load_gmsh to allow running outside the main thread.
Fixed trailing whitespace issue. Added optional argument to load_gmsh to enable it to run outside the main thread.
Docs/documentation fixes
Update gmsh.py
Fix typing bug in merge_vertices function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scene.scaled
returned an invalid camera if it had been defined.trimesh.scene.reconstruct_instances
which usestrimesh.registration.procrustes
and is actually very fast (10x faster on some simple data thanscene.duplicate_nodes
) and gives great results on baked scenes.trimesh.registration
Scene.simplify_quadric_decimation
which runsmesh.simplify_quadric_decimation
for every mesh geometry in the scene.trimesh.convex.QhullOptions
dataclass with a blurb for every boolean flag option in 8b2d46e, so you can construct this string with something likeQhullOptions(QbB=True)
and read the docstrings as you're doing it.VIRTUAL_ENV
variable in the Dockerfile which lets upstream potentially useuv
.body
to the Github releases in CI.Scene.dump(concatenate=True)
which should be replaced withScene.to_geometry()
orScene.to_mesh()
, as otherwise the return types are inconsistent. This also lays some groundwork for [WIP] Refactor Load Types #2241 astrimesh.load_mesh
will be a thin wrapper aroundtrimesh.load_scene(...).to_mesh()
Scene.deduplicated
is removed because it's one line and also mildly pointless, you can get the same effect withScene(list({g.identifier_hash: g for g in self.geometry.values()}.values())
)