Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update bevy to 0.12 #3

Merged
merged 5 commits into from
Nov 19, 2023
Merged

feat: update bevy to 0.12 #3

merged 5 commits into from
Nov 19, 2023

Conversation

mikeder
Copy link
Owner

@mikeder mikeder commented Nov 18, 2023

  1. Update Bevy to 0.12
  2. Update related deps ( ggrs, bevy_ggrs, matchbox, etc. )
  3. Log warning if winit cannot find main window to avoid panic - I don't understand why this changed see below.
  4. Switch to 1.72 toolchain due to Rust compiler regression.

Winit Panic

Some new issue was introduced with the Bevy 0.12 upgrade, this line started panicking, so we just log a warning and abort if we can't get the primary window.

https://github.com/mikeder/turtletime/pull/3/files#diff-42cb6807ad74b3e201c5a7ca98b911c5fa08380e942be6e4ac5807f8377f87fcL83

NiklasEi/bevy_game_template#80

Compiler Regression

I was unable to compile bevy-egui-inspector after updating to Rust to the 1.74 toolchain, it turns out there was a compiler regression so I've pinned my toolchain to 1.72 ( there was another regression in 1.73 that sounds nasty enough to avoid for now too )

jakobhellermann/bevy-inspector-egui#163
rust-lang/rust#117976

Segmentation Fault

Originally I tried to use the nightly toolchain as recommended in the above bevy-egui-inspector issue, but when I did, my game instantly crashed with a segmentation fault. I tried to use the sanitizer features to debug it, but the game compiled and ran just fine with the sanitizer flags. Ultimately I just downgraded to 1.72 and moved on with my life.

@mikeder mikeder changed the title Feat/update bevy 012 feat: update bevy to 0.12 Nov 19, 2023
@mikeder mikeder merged commit 8f0e974 into main Nov 19, 2023
10 checks passed
@mikeder mikeder deleted the feat/update-bevy-012 branch November 19, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant