Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UriPrintConnector #535

Merged
merged 2 commits into from
Mar 13, 2018
Merged

Add UriPrintConnector #535

merged 2 commits into from
Mar 13, 2018

Conversation

mike42
Copy link
Owner

@mike42 mike42 commented Mar 12, 2018

This adds the UriPrintConnector contributed by @evsar3.

Reference:

@mike42 mike42 changed the title [WIP] add UriPrintConnector Add UriPrintConnector Mar 13, 2018
@mike42
Copy link
Owner Author

mike42 commented Mar 13, 2018

I've refactored this to add tests.

I've also reduced the scope to URI schemes that are likely to work as expected in escpos-php. Things like IPP (not actually supported in CupsConnector) and lpt (not a real URI scheme, depends on client platform) have been taken out so that this feature does not have a negative impact on usability.

@mike42 mike42 merged commit d51f040 into development Mar 13, 2018
@mike42 mike42 deleted the 314-uri-print-connector branch March 13, 2018 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant