About REGEX_SMB constant #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today I had a problem while using a password with the + character. The library was throwing the BadMethodCallException located at line 155. So, to avoid it I added the + character in the REGEX_SMB constant. This will allow the connector to work with passwords that have such symbol. It would be a good idea to allow more special characters on passwords and maybe users. I guess a little research would be needed to know which ones should be allowed.
|
Cheers, agree completely. Because of the way printing works on Windows (copying to a share path), the regex is necessary to prevent the printer driver from being hijacked to write files to arbitrary paths, in case the printer URL is user-supplied. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I had a problem while using a password with the + character. The library was throwing the BadMethodCallException located at line 155. So, to avoid it I added the + character in the REGEX_SMB constant. This will allow the connector to work with passwords that have such symbol. It would be a good idea to allow more special characters on passwords. I guess a little research would be needed to know which ones should be allowed.