Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent error on mixin when remove innexisting listener ember 3.12 #317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

romgere
Copy link

@romgere romgere commented Feb 28, 2020

On ember 3.12, on acceptance test we encountered the error below :

You attempted to remove a function listener which did not exist on the instance, which means you may have attempted to remove it before it was added.

The error is throwed by the resize-aware mixin inside the willDestroyElement method when trying to remove the didResize and/or debouncedDidResize listener.
From my understanding, the willDestroyElement is called without a call to didInsertElement.

This PR aim to fix this.

Related to #316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant