Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is the initializer add-modals-container still needed? #765

Open
Gorzas opened this issue Jun 6, 2019 · 0 comments · May be fixed by #766
Open

Is the initializer add-modals-container still needed? #765

Gorzas opened this issue Jun 6, 2019 · 0 comments · May be fixed by #766

Comments

@Gorzas
Copy link
Contributor

Gorzas commented Jun 6, 2019

I've seen that the library ember-modal-dialog has been updated to version 3.0.0. This initializer overrides the one in the dependency and I think it's not needed anymore, unless there's some compatibility issue.

I've tested the library without the initializer and keeps working as usual. Doing a PR removing it waiting for some feedback from the community.
Gorzas added a commit to Neuromobile/ember-cli-materialize that referenced this issue Jun 6, 2019
@Gorzas
feat: remove add-modals-container initializer
082bd0c 
Close mike-north#765
@Gorzas Gorzas linked a pull request Jun 6, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove add-modals-container initializer Neuromobile/ember-cli-materialize
1 participant
@Gorzas