Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createInlineWidgets is not a function #187

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AmilKey
Copy link

@AmilKey AmilKey commented Mar 8, 2019

@ghost
Copy link

ghost commented Mar 8, 2019

There were the following issues with this Pull Request

  • Commit: c894bde
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

index.js Outdated
@@ -10,8 +10,7 @@ module.exports = {

if (type === 'head') {
content =
'<script async type="text/javascript" src="https://calendly.com/assets/external/widget.js"></script>' +
'<link href="https://calendly.com/assets/external/widget.css" rel="stylesheet">';
'<script type="text/javascript" src="https://assets.calendly.com/assets/external/widget.js"></script>';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reasoning for this change? Removal of the async attribute would make downloading this script block HTML rendering

@ghost
Copy link

ghost commented Mar 11, 2019

There were the following issues with this Pull Request

  • Commit: c894bde
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: b3da28e
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Mar 11, 2019

There were the following issues with this Pull Request

  • Commit: c894bde
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: b3da28e
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: 830ad9f
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@AmilKey AmilKey changed the title change widget url createInlineWidgets is not a function Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants