-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
createInlineWidgets is not a function #187
base: master
Are you sure you want to change the base?
Conversation
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
index.js
Outdated
@@ -10,8 +10,7 @@ module.exports = { | |||
|
|||
if (type === 'head') { | |||
content = | |||
'<script async type="text/javascript" src="https://calendly.com/assets/external/widget.js"></script>' + | |||
'<link href="https://calendly.com/assets/external/widget.css" rel="stylesheet">'; | |||
'<script type="text/javascript" src="https://assets.calendly.com/assets/external/widget.js"></script>'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reasoning for this change? Removal of the async
attribute would make downloading this script block HTML rendering
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
#188