Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster tests #101

Merged
merged 13 commits into from
Nov 26, 2021
Merged

cluster tests #101

merged 13 commits into from
Nov 26, 2021

Conversation

mike-marcacci
Copy link
Owner

@mike-marcacci mike-marcacci commented Aug 7, 2021

  • Add cluster tests
  • Skip cluster tests in CI
  • Write documentation about using hashtags to force the keys into the same hash slot

This also fixes #111.

This tests behaviors in cluster environments.
The suite of cluster tests requires a significant number of redis instances, which I'm going to avoid creating in GH actions right now.
@mike-marcacci mike-marcacci marked this pull request as ready for review October 15, 2021 15:29
@mike-marcacci mike-marcacci marked this pull request as draft November 11, 2021 01:30
We tend to get test errors due to unready redis clusters when they are spun up alongside the runner service. This adds a delay as a hack around this.
@mike-marcacci mike-marcacci marked this pull request as ready for review November 26, 2021 17:14
@mike-marcacci mike-marcacci merged commit b75a5f4 into main Nov 26, 2021
@mike-marcacci mike-marcacci deleted the cluster-tests branch November 26, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run on Docker
1 participant