Skip to content

test: strengthen helper_identifier_hover_works_in_blade_embedded_php to assert card content #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikebronner merged 2 commits into from
Jun 15, 2026
Merged

test: strengthen helper_identifier_hover_works_in_blade_embedded_php to assert card content #144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c98f4d8
chore: start work on #136
mikebronner Jun 15, 2026
afbebda
✅ test: assert card content in blade-embedded helper hover
mikebronner Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions laravel-lsp/src/tests/helper_identifier_hover.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,15 @@ fn helper_identifier_hover_works_in_blade_embedded_php() {
.iter()
.find(|h| h.name == "route")
.expect("route helper identifier captured in Blade-embedded PHP");
// The card renders the same regardless of host file type.
assert!(hover::helper_identifier_card(&route.name, None).is_some());
// The card renders the same regardless of host file type — assert its
// content, not mere existence, so a wrong or empty card can't pass.
let card = hover::helper_identifier_card(&route.name, None)
.expect("route is curated, so a card renders in Blade-embedded PHP too");
assert!(card.contains("**route**"), "card headers the helper name");
assert!(
card.contains("named route"),
"card carries the Laravel-aware synopsis"
);
}

#[test]
Expand Down