Remove Python 2 support #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, remove dependency on Six: Python 2 and 3 Compatibility Library. Python 2 support was removed from FEniCS since 2018.1.0 and FEniCS docker images no longer include python-six.
|
Do you want me to add you as collaborator @benzwick ? So you don't have to create a PR for every typo you find:-) I'm currently more involved in the spectralDNS project and it would be great if someone like yourselves, that is using Oasis with current Fenics version, could help make sure the code is up to date. |
|
That would be great @mikaem Most of the examples now run with FEniCS 2018.1.0 but there are still some with errors and some that don't run with MPI. Should I create issues to document these? |
|
Yes, please create some issues of remaining errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not run Oasis inside a container because:
Python 2 support was removed from FEniCS since 2018.1.0 and FEniCS docker images no longer include python-six. Since FEniCS no longer supports Python 2 we can also remove it from Oasis.