More fixes to make Oasis work with FEniCS 2018.1.0 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See FEniCS 2017.2.0 changelog: Deprecate VertexFunction, EdgeFunction, FaceFunction, FacetFunction, CellFunction; use MeshFunction instead
Warning seems to have been removed from DOLFIN: NameError: name 'warning' is not defined
See FEniCS 2017.2.0 changelog: Deprecate subclassing of Expression in Python; new Python class UserExpression introduced for user overloads
DOLFIN (2018.1.0) now uses pybind11 for wrapping C++ and does not allow the implementation of dynamic attributes. This commit fixes the following error: AttributeError: 'dolfin.cpp.io.XDMFFile' object has no attribute 'uv'
Parameters "same_nonzero_pattern" and "reuse_factorization" deprecated. Attempting to set them causes a segmentation fault. See DOLFIN commits: - https://bitbucket.org/fenics-project/dolfin/commits/29ce62d9942ea27821373506c4537eb174bd8816 - https://bitbucket.org/fenics-project/dolfin/commits/7ab838869df6b9d0b8b049ed4b203f2cd3e7862c
NameError: name 'set_log_active' is not defined Perhaps there is no pybind11 wrapper for this yet.
DOLFIN (2018.1.0) now uses pybind11 for wrapping C++ and does not allow the implementation of dynamic attributes. This commit fixes the following error: AttributeError: 'dolfin.cpp.la.LUSolver' object has no attribute 'normalize'
mikaem
reviewed
Dec 30, 2018
| if not hasattr(tstepfile, 'uv'): | ||
| tstepfile.uv = AssignedVectorFunction(u_) | ||
| # Create vector function and assigners | ||
| uv = AssignedVectorFunction(u_) |
There was a problem hiding this comment.
Only problem here is that now this vector function will be created new every time. That is not efficient, but then again, it's not a big deal. Can be fixed later on.
|
Thanks a lot @benzwick for this update. Seems to me that it's all minor changes so I'll just go ahead and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the example problems now run with FEniCS 2018.1.0.
The following problems still have some issues that I was unable to fix: