Fixes for fenics 2018.1.0 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @benzwick :-) |
|
No worries @mikaem. There are still a few more issues with some of the examples. Shall I continue to work on this branch now that the changes have been merged or delete it and create a new branch for more fixes? |
|
The best approach is to delete this branch and create a new one. Thanks again😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some problems I had when trying to run Oasis with FEniCS 2018.1.0. Both CellSize() and MPI.com_world.Get_rank() seem to have been deprecated:
AttributeError: 'dolfin.cpp.MPICommWrapper' object has no attribute 'Get_rank'