Add weekend styling option #182
Conversation
ubhaller
force-pushed
the
feature/weekend
branch
from
19a15b9 to
a4025d6
Compare
|
If I understand it right, this isn't quite an option but we're making weekends styled with red. I feel the red conveys a quite different user experience than the existing model. I went to check how Google Flights and Linear do it (they're like my references for the date picker lol) and Google does not highlight weekends at all, while Linear does it with the same light grey used to represent dates in the prev/next months. I think this should be grey by default instead of red, and it should also be a configurable option (would it be on or off by default?) |
| @@ -695,6 +697,8 @@ pub mod date { | |||
| } | |||
| } else if date_it == today { | |||
| style_sheet = self.render_config.calendar.today_date; | |||
| } else if is_weekend(date_it) { | |||
There was a problem hiding this comment.
It won't make a difference when both colors are the same, but in the case they're different, I think the (day in the prev/next month) style should have precedence over the (day is weekend) style.
Like in this example:
I feel the second screenshot represents a better UX when parsing the calendar
| @@ -497,6 +501,7 @@ pub mod calendar { | |||
| today_date: StyleSheet::empty().with_fg(Color::LightGreen), | |||
| different_month_date: StyleSheet::empty().with_fg(Color::DarkGrey), | |||
| unavailable_date: StyleSheet::empty().with_fg(Color::DarkGrey), | |||
| weekend: StyleSheet::empty().with_fg(Color::DarkRed), | |||
There was a problem hiding this comment.
| weekend: StyleSheet::empty().with_fg(Color::DarkRed), | |
| weekend: StyleSheet::empty().with_fg(Color::DarkGrey), |
It's not that I necessarily defend grey as being the ultimate UX choice, but I think the red implies some information in a way, as if it's an unavailable date.
| @@ -13,6 +13,7 @@ | |||
| - Add strict clippy lints to improve code consistency and readability. | |||
| - Expand workflow clippy task to lint all-features in workspace. | |||
| - Add docs badge to readme. | |||
| - Add date select option to apply style to weekend days [#182](https://github.com/mikaelmello/inquire/pull/182). | |||
There was a problem hiding this comment.
| - Add date select option to apply style to weekend days [#182](https://github.com/mikaelmello/inquire/pull/182). | |
| - **Breaking**. Enabled by default, added date select option to apply style to weekend days [#182](https://github.com/mikaelmello/inquire/pull/182). |
Add date select option to apply style to weekend days