forked from WordPress/gutenberg
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] PoC: Offline editing #1
Draft
miina
wants to merge
4
commits into
master
Choose a base branch
from
feature/offline-editing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
/* @todo This file should be moved to a better location. */ | ||
/* global wp, fetch, caches, ERROR_OFFLINE_URL, ERROR_MESSAGES, ERROR_500_URL */ | ||
|
||
// IIFE is used for lexical scoping instead of just a braces block due to bug with const in Safari. | ||
( () => { | ||
const queue = new wp.serviceWorker.backgroundSync.Queue( 'gutenbergPendingEdits' ); | ||
|
||
const editPostHandler = ( { url, event } ) => { | ||
const clone = event.request.clone(); | ||
return fetch( event.request ) | ||
.then( ( response ) => { | ||
return response; | ||
} ) | ||
.catch( () => { | ||
const bodyPromise = clone.blob(); | ||
bodyPromise.then( | ||
function( body ) { | ||
const request = event.request; | ||
const req = new Request( request.url, { | ||
method: request.method, | ||
headers: request.headers, | ||
mode: 'same-origin', | ||
credentials: request.credentials, | ||
referrer: request.referrer, | ||
redirect: 'manual', | ||
body, | ||
} ); | ||
|
||
// Add request to queue. | ||
queue.pushRequest( { | ||
request: req, | ||
} ); | ||
} | ||
); | ||
} ); | ||
}; | ||
|
||
wp.serviceWorker.routing.registerRoute( | ||
/\/index\.php/, | ||
editPostHandler, | ||
'POST' | ||
); | ||
} )(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
<?php | ||
|
||
if ( ! defined( 'ABSPATH' ) ) { | ||
die( 'Silence is golden.' ); | ||
} | ||
|
||
function gutenberg_register_offline_editing_service_worker_script( $scripts ) { | ||
$scripts->register( | ||
'gutenberg-offline-editing', | ||
array( | ||
'src' => plugin_dir_url( __FILE__ ) . 'offline-editing.js', | ||
'deps' => array( 'wp-base-config' ), | ||
) | ||
); | ||
} | ||
|
||
add_action( 'wp_admin_service_worker', 'gutenberg_register_offline_editing_service_worker_script' ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should check that it's actually for editing the post
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the
index.php
here imply that pretty permalinks are not enabled?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's currently the case.