Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for tracker URLs inside mihon #469

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Shamicen
Copy link
Contributor

@Shamicen Shamicen commented Mar 2, 2024

I implemented a field for website URLs.

Features:

Users can open a tracker-links manga inside the Mihon tracker search by pressing "Open in Mihon:


(Only logged in trackers have this option)

New custom icons for every external tracker:

Other

  • Tracker use their name inside the Chip.
  • I still need to implement URL validation for Http-Source manga. I would like some feedback about the best place to do this.
  • Kitsu and MangaUpdates do not have the manga id in their tracker URLs, so I'm only performing a normal search at the moment.
  • We could implement a copy metadata from tracker button once Edit basic Manga information #398 is merged.
  • The chip will only be shown if its manga is not already being tracked.
  • The MyAnimeList logo has 2 versions, the current one is the "stretched" version, we could change back to the normal version if wanted.

Icons

I used the program mentioned in CustomIcons.kt (https://github.com/DevSrSouza/svg-to-compose) to turn the svg files into Kotlin code

The icons are from the following sources:
MyAnimeList: (CC0 License) https://icon-icons.com/icon/myanimelist-logo/248409
Anilist: (CC0 License) https://www.svgrepo.com/svg/329929/anilist
Kitsu: (CC0 License) https://www.svgrepo.com/svg/330791/kitsu
Shikimori: (CC0 License) https://www.svgrepo.com/svg/306721/shikimori
MangaUpdates: I used the image inside res/drawable-nodpi/ and made a svg from it.
Bangumi: I used the image inside res/drawable-nodpi/ and made a svg from it.

All external Icons are licensed under CC0

@AntsyLich
Copy link
Member

Tracker is one thing but like only 2 site I know include those, Not really interested in other web links.

@Shamicen
Copy link
Contributor Author

Shamicen commented Mar 3, 2024

Tracker is one thing but like only 2 site I know include those, Not really interested in other web links.

OK I'll change it to only display tracker links.

@Shamicen
Copy link
Contributor Author

Shamicen commented Mar 6, 2024

OK I'll change it to only display tracker links.

Done

@Shamicen Shamicen changed the title Support for tracker and other website URLs inside mihon. Support for tracker URLs inside mihon Mar 11, 2024
@AntsyLich
Copy link
Member

Can you extract the non-ui bit on a separate pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants