Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons/folder-icons for different Storybook folders #228

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

dimentoree
Copy link
Contributor

@dimentoree dimentoree commented Aug 2, 2024

Hi @miguelsolorio, I noticed that there are no folder icons for the Storybook and decided to add icons for it
I chose the color based on the logo of the Storybook itself and also by analogy added other icons that are associated with pink

@dimentoree dimentoree changed the title Add icons/folder-icons for different storybook folders Add icons/folder-icons for different Storybook folders Aug 2, 2024
@miguelsolorio
Copy link
Owner

miguelsolorio commented Aug 2, 2024

Thanks for the PR, do you mind updating the description to include a screenshot?

Also, these appear to be generic folder/file icons. Did you intend to add Storybook versions?

@dimentoree
Copy link
Contributor Author

dimentoree commented Aug 2, 2024

Yes, I can add a screenshot of those folders later

Regarding generic folders, I tried to stick to the general style you specified (for example, if a file starts with ., the folder will have a circle in the lower right corner, like .vcode or .next).
Also I decided to add a couple of generic icons right away, because I saw similar variations for blue, green, and other colors (maybe they will come in handy in the future to describe some other files or folders).

I think this style of generic folders suits better than a folder with a storybook logo)

@miguelsolorio miguelsolorio self-requested a review August 5, 2024 06:04
@miguelsolorio miguelsolorio self-assigned this Aug 5, 2024
@miguelsolorio miguelsolorio added this to the 0.0.19 milestone Aug 5, 2024
Copy link
Owner

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫶 Thanks for the PR!

@miguelsolorio miguelsolorio merged commit fd84b31 into miguelsolorio:main Aug 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants