Fix occasional server disconnect crashes (Fixes #146)

miguelgrinberg · Nov 17, 2019 · 9f96cd8 · 9f96cd8
1 parent 3c221aa
commit 9f96cd8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/engineio/asyncio_server.py b/engineio/asyncio_server.py
@@ -168,7 +168,8 @@ async def disconnect(self, sid=None):
                 pass
             else:
                 await socket.close()
-                del self.sockets[sid]
+                if sid in self.sockets:  # pragma: no cover
+                    del self.sockets[sid]
         else:
             await asyncio.wait([client.close()
                                 for client in six.itervalues(self.sockets)])

diff --git a/engineio/server.py b/engineio/server.py
@@ -289,7 +289,8 @@ def disconnect(self, sid=None):
                 pass
             else:
                 socket.close()
-                del self.sockets[sid]
+                if sid in self.sockets:  # pragma: no cover
+                    del self.sockets[sid]
         else:
             for client in six.itervalues(self.sockets):
                 client.close()