feat: update ESLint & TypeScript plugin #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `eslint-config-standard` has been updated to `13.0.1`. BREAKING CHANGE: Updatd all peer dependencies. Fixes #80. Fixes #94. Added option for rule `@typescript-eslint/explicit-function-return-type`: `allowHigherOrderFunctions: true`. BREAKING CHANGE: `typescript-eslint/parser` is no longer a `peerDependency`, but a `dependency`. Users should remove it from their configuration, as well. Closes #65. Updated `@typescript-eslint/eslint-plugin` to `1.10.2`.
LinusU
reviewed
Aug 5, 2019
| 'camelcase': 'off', // in favor of TypeScript rule | ||
| 'indent': 'off', | ||
| camelcase: 'off', // in favor of TypeScript rule | ||
| indent: 'off', |
There was a problem hiding this comment.
I think that the new rule in Standard 14 is that all lines should have ' if at least one row needs it 😄 🤔
There was a problem hiding this comment.
@LinusU Actually, we went with the rule that we only need ' on lines where it's needed. In other words, this is okay:
const obj = {
'hi-there': 1,
hey: 2
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
eslint-config-standardhas been updated to13.0.1.BREAKING CHANGE: Updatd all peer dependencies. Fixes #80. Fixes #94.
Added option for rule
@typescript-eslint/explicit-function-return-type:allowHigherOrderFunctions: true.BREAKING CHANGE:
typescript-eslint/parseris no longer apeerDependency, but adependency. Users should remove it from their configuration, as well. Closes #65.Updated
@typescript-eslint/eslint-pluginto1.10.2.