Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcut reference doc or window popout #726

Open
mklaber opened this issue Apr 18, 2021 · 5 comments
Open

Keyboard shortcut reference doc or window popout #726

mklaber opened this issue Apr 18, 2021 · 5 comments

Comments

@mklaber
Copy link
Contributor

mklaber commented Apr 18, 2021

Is your feature request related to a problem? Please describe.

This could be seen as a workaround for #654 though has value in and of itself.

Describe the solution you'd like

It would be helpful to have a keyboard shortcut reference sheet available outside of the app (rather than only as a help menu within the app that has to be dismissed in order to start using a key command). This reference sheet could be in a GH wiki, added to the README, or as a separate Markdown file perhaps generated by capturing these lines from HelpSheet.jsx.

Describe alternatives you've considered

Alternatively, the HelpSheet could open in separate window. (Not practical for Electron)

Additional context

YouTube has a couple of examples of describing keys. There's a help doc as well as SHIFT + ? while playing a video:
image

@mifi
Copy link
Owner

mifi commented Aug 23, 2021

Maybe we could store the keyboard shortcuts as markdown and then it would automatically be shown on github, while lossless-cut could import and render the markdown file. One problem is that it could get messy/tedious if we want to have multi language support.

mifi added a commit that referenced this issue Feb 20, 2022
@mifi
Copy link
Owner

mifi commented Feb 20, 2022

shift+/ (?) will now show/hide the new keyboard dialog popup similar to youtube

@mifi mifi changed the title Keyboard shortcut reference doc Keyboard shortcut reference doc or window popout Oct 13, 2022
mifi added a commit that referenced this issue Oct 14, 2022
@mifi
Copy link
Owner

mifi commented Oct 14, 2022

created a branch with an experiment but it doesn't quite work 100%:
https://github.com/mifi/lossless-cut/compare/react-window-popout

Current issues:

  • there are no styles in the popout window
  • modals like Dialog opened in the popout window gets instead opened in the main LosslessCut window

@zwei7
Copy link

zwei7 commented Apr 30, 2024

Show the shortcut when you hover over a button in the helpful hints popup window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants