Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore if in progress before queued #15

Merged
merged 3 commits into from
Feb 17, 2023
Merged

Conversation

arponpes
Copy link
Collaborator

@arponpes arponpes commented Feb 17, 2023

Due to a bug with github webhooks, occasionally the in progress date is before the queued date, as you can see in the following example.

  "action": "in_progress",
  "workflow_job": {
    "id": 11410137540,
    "run_id": 4201434196,
    "workflow_name": "Main CI",
    "head_branch": "ape/wasm-log/enable-logging",
    "run_url": "https://api.github.com/repos/midokura/evp-device-agent/actions/runs/4201434196",
    "run_attempt": 1,
    "node_id": "CR_kwDODoNrLs8AAAACqBjhxA",
    "head_sha": "3645b32e8addf1d011a267fde04584cb0cc81fe4",
    "url": "https://api.github.com/repos/midokura/evp-device-agent/actions/jobs/11410137540",
    "html_url": "https://github.com/midokura/evp-device-agent/actions/runs/4201434196/jobs/7288440127",
    "status": "in_progress",
    "conclusion": null,
    "started_at": "2023-02-17T06:57:46Z",```

{
  "action": "queued",
  "workflow_job": {
    "id": 11410137540,
    "run_id": 4201434196,
    "workflow_name": "Main CI",
    "head_branch": "ape/wasm-log/enable-logging",
    "run_url": "https://api.github.com/repos/midokura/evp-device-agent/actions/runs/4201434196",
    "run_attempt": 1,
    "node_id": "CR_kwDODoNrLs8AAAACqBjhxA",
    "head_sha": "3645b32e8addf1d011a267fde04584cb0cc81fe4",
    "url": "https://api.github.com/repos/midokura/evp-device-agent/actions/jobs/11410137540",
    "html_url": "https://github.com/midokura/evp-device-agent/actions/runs/4201434196/jobs/7288440127",
    "status": "queued",
    "conclusion": null,
    "started_at": "2023-02-17T06:57:48Z",

due to that, I think the best option is to ignore this errors that not frequent.
Also I'm deleting time_to_start from the logs so it doesn't count for the metrics.

@arponpes arponpes force-pushed the fix_in_progress_before_queued branch 2 times, most recently from b93630b to 43cdf1e Compare February 17, 2023 11:51
@arponpes arponpes force-pushed the fix_in_progress_before_queued branch from 43cdf1e to 6fb6194 Compare February 17, 2023 11:55
@arponpes arponpes marked this pull request as ready for review February 17, 2023 11:58
@arponpes arponpes requested a review from a team February 17, 2023 12:05
@arponpes arponpes self-assigned this Feb 17, 2023
Copy link
Contributor

@duhow duhow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds ok, but please keep same logging level.

src/app.py Outdated Show resolved Hide resolved
src/app.py Outdated Show resolved Hide resolved
arponpes and others added 2 commits February 17, 2023 14:36
Co-authored-by: David Girón <[email protected]>
Co-authored-by: David Girón <[email protected]>
@arponpes arponpes requested a review from duhow February 17, 2023 13:37
@arponpes arponpes merged commit acbbe0b into main Feb 17, 2023
@arponpes arponpes deleted the fix_in_progress_before_queued branch February 17, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants