Skip to content

chore: updated SDK to polkadot-stable2512-3#1262

Merged
gilescope merged 4 commits intomainfrom
stable2512
Apr 10, 2026
Merged

chore: updated SDK to polkadot-stable2512-3#1262
gilescope merged 4 commits intomainfrom
stable2512

Conversation

@Klapeyron
Copy link
Copy Markdown
Contributor

@Klapeyron Klapeyron commented Apr 8, 2026

Overview

This PR bumps Substrate / Polkadot SDK dependencies to polkadot-stable2512-3 (parity tag on polkadot-sdk) and applies the follow-on API changes required for that release. The goal is to stay aligned with upstream stable2512 and with the partner-chains stack (see partner-chains#28). Required for #1244

Runtime / API

  • sp_api::Core: execute_block now takes <Block as BlockT>::LazyBlock instead of Block; the implementation forwards directly to Executive::execute_block, which expects a lazy block in this SDK version.
  • sp_block_builder::BlockBuilder: check_inherents likewise takes LazyBlock; InherentData::check_extrinsics is called with that type.
  • mmr::MmrApi: API version 3 adds generate_ancestry_proof on the runtime API (ancestry proof generation was removed from BeefyApi in this line). The runtime implements it by delegating to pallet_mmr::Pallet::generate_ancestry_proof, and the MmrApi impl is annotated with #[api_version(3)] to match upstream runtimes (e.g. Westend / node template).
  • BeefyApi: generate_ancestry_proof is not implemented on BeefyApi anymore in stable2512-3; callers should use MmrApi::generate_ancestry_proof instead.
  • Removed an unused Encode import in the runtime where it became redundant.

Node

  • sc_service::SpawnTasksParams: new field tracing_execute_block (Option<Arc<dyn TracingExecuteBlock<_>>>). Set to None unless you wire up trace_block RPC tracing (matches upstream solochain / node CLI templates).

Tests / mocks

  • pallet-version mock: impl sp_api::Core uses execute_block(_: <Block as BlockT>::LazyBlock) for the same Core API change.

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

@Klapeyron Klapeyron self-assigned this Apr 8, 2026
@Klapeyron Klapeyron force-pushed the stable2512 branch 2 times, most recently from ccc7239 to 80c820d Compare April 8, 2026 14:21
@Klapeyron Klapeyron marked this pull request as ready for review April 8, 2026 14:35
@Klapeyron Klapeyron requested a review from a team as a code owner April 8, 2026 14:35
Base automatically changed from ozgb-toolkit-subxt-bump to main April 8, 2026 15:29
@Klapeyron Klapeyron force-pushed the stable2512 branch 3 times, most recently from 0292758 to 2a3fd8f Compare April 10, 2026 06:58
@gilescope gilescope enabled auto-merge April 10, 2026 12:52
@gilescope gilescope added this pull request to the merge queue Apr 10, 2026
Merged via the queue into main with commit 8242198 Apr 10, 2026
32 checks passed
@gilescope gilescope deleted the stable2512 branch April 10, 2026 13:55
m2ux added a commit that referenced this pull request Apr 23, 2026
* chore: updated SDK to polkadot-stable2512-3

* chore: updated SDK for partner-chains to polkadot-stable2512-3

---------

Co-authored-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Co-authored-by: Squirrel <giles.cope@shielded.io>
Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux added a commit that referenced this pull request Apr 23, 2026
* chore: updated SDK to polkadot-stable2512-3

* chore: updated SDK for partner-chains to polkadot-stable2512-3

---------

Co-authored-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Co-authored-by: Squirrel <giles.cope@shielded.io>
Signed-off-by: Mike Clay <mike.clay@shielded.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prepare a PR to upgrade midnight-node pointing to update stable2512 PC branch

4 participants