Fixed API issues #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you @rdridder , Same environment used for the pull request on uClock? |
Contributor
Author
|
Yes indeed, all code was written on the same environment. Cheers, Ron |
- fix esp32 initTimer to expected uCtrl microseconds interval.
Owner
|
great, i just have to edit the initTimer to the init_clock variable, otherwise uctrl will not behave as expected(current 250us is the time interval call of this interrupt) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Guys,
I have fixed some API issues. I was building Aciduino and it did not compile.
Issue 1
The timer handling changed in the ESP32 Arduino libraries, see documentation: https://docs.espressif.com/projects/arduino-esp32/en/latest/api/timer.html
Issue 2
std::string is now changed to String.
espressif/arduino-esp32#8724
https://github.com/espressif/arduino-esp32/blob/master/libraries/BLE/src/BLECharacteristic.h
I have adjusted the code so it compiles again.
Cheers,
Ron